Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Fix enableReplicatedSubscriptions #23781

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nodece
Copy link
Member

@nodece nodece commented Dec 25, 2024

Motivation

#23757 breaks enableReplicatedSubscriptions config.

Modifications

When enableReplicatedSubscriptions=false, disable the subscription replication.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@nodece nodece requested review from lhotari and dao-jun December 25, 2024 09:11
@nodece nodece self-assigned this Dec 25, 2024
@nodece nodece added this to the 4.1.0 milestone Dec 25, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 25, 2024
@nodece nodece closed this Dec 25, 2024
@nodece nodece reopened this Dec 25, 2024
@nodece
Copy link
Member Author

nodece commented Dec 25, 2024

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.19%. Comparing base (bbc6224) to head (67ffaa8).
Report is 815 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23781      +/-   ##
============================================
+ Coverage     73.57%   74.19%   +0.61%     
+ Complexity    32624    32141     -483     
============================================
  Files          1877     1853      -24     
  Lines        139502   143376    +3874     
  Branches      15299    16277     +978     
============================================
+ Hits         102638   106373    +3735     
+ Misses        28908    28629     -279     
- Partials       7956     8374     +418     
Flag Coverage Δ
inttests 26.81% <33.33%> (+2.23%) ⬆️
systests 23.22% <33.33%> (-1.10%) ⬇️
unittests 73.70% <100.00%> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...sar/broker/service/persistent/PersistentTopic.java 79.93% <100.00%> (+1.47%) ⬆️

... and 1019 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants