[improve][broker] Improve SystemTopicBasedTopicPoliciesService reader to reduce GC pressure #23780
+23
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make the reader referenced by SystemTopicBasedTopicPoliciesService pooling messages to reduce GC pressure.
If
poolMessage=false
of the Reader, pulsar client will copy message payload into heap without pooling.Generally, it is not recommended to users use the feature, because it requires call
message.release()
manually, or it will lead to mem leak.However, in the broker side, we need this feature to improve JVM GC performance.
Especially for there is a big number of topics served by a single broker.
Modifications
poolMessage=true
when SystemTopicBasedTopicPoliciesService component creating a readermessage.release()
manually after process messages.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: