-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #13873 #13875
Fix #13873 #13875
Conversation
@leducp could you switch one defconfig to link toolchain's libcxx? |
ping @xuxin930 Can you test this PR with your MSVC setup to ensure no regression on your side? |
Yes I am planning to do so, but it will not be sufficient: we need a user app that use a few tools from the standard C++ library to catch theses kind of errors. |
it's enough to enable apps/testing/cxxtest/
it simple to add/modify one defconfig under boards/, ci will build your defconfig automatically. |
I enabled the cxxtest app and the C++ toolchain with all options (RTTI, exceptions, etc) on the xmc4800-relax. Let me know if this is OK |
looks fine. |
Summary
#13755 break C++ build with GCC libstdc++. This PR re-enable the macro while takin care of MSVC build.
Impact
Fix #13873 - build on G++ while keeping MSVC happy.
Testing
Only with GCC, I do not have tools to test on MSVC.