Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #13873 #13875

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Fix #13873 #13875

merged 2 commits into from
Oct 8, 2024

Conversation

leducp
Copy link
Contributor

@leducp leducp commented Oct 7, 2024

Summary

#13755 break C++ build with GCC libstdc++. This PR re-enable the macro while takin care of MSVC build.

Impact

Fix #13873 - build on G++ while keeping MSVC happy.

Testing

Only with GCC, I do not have tools to test on MSVC.

@github-actions github-actions bot added Area: OS Components OS Components issues Size: S The size of the change in this PR is small labels Oct 7, 2024
@xiaoxiang781216
Copy link
Contributor

@leducp could you switch one defconfig to link toolchain's libcxx?

@leducp
Copy link
Contributor Author

leducp commented Oct 7, 2024

ping @xuxin930 Can you test this PR with your MSVC setup to ensure no regression on your side?

@leducp
Copy link
Contributor Author

leducp commented Oct 7, 2024

@leducp could you switch one defconfig to link toolchain's libcxx?

Yes I am planning to do so, but it will not be sufficient: we need a user app that use a few tools from the standard C++ library to catch theses kind of errors.
I can add something but I do not know how to tell the CI to use it. Any clue?

@xiaoxiang781216
Copy link
Contributor

@leducp could you switch one defconfig to link toolchain's libcxx?

Yes I am planning to do so, but it will not be sufficient: we need a user app that use a few tools from the standard C++ library to catch theses kind of errors.

it's enough to enable apps/testing/cxxtest/

I can add something but I do not know how to tell the CI to use it. Any clue?

it simple to add/modify one defconfig under boards/, ci will build your defconfig automatically.

@github-actions github-actions bot added the Area: Board support Board support issues label Oct 7, 2024
@leducp
Copy link
Contributor Author

leducp commented Oct 7, 2024

@leducp could you switch one defconfig to link toolchain's libcxx?

Yes I am planning to do so, but it will not be sufficient: we need a user app that use a few tools from the standard C++ library to catch theses kind of errors.

it's enough to enable apps/testing/cxxtest/

I can add something but I do not know how to tell the CI to use it. Any clue?

it simple to add/modify one defconfig under boards/, ci will build your defconfig automatically.

I enabled the cxxtest app and the C++ toolchain with all options (RTTI, exceptions, etc) on the xmc4800-relax. Let me know if this is OK

@xiaoxiang781216
Copy link
Contributor

looks fine.

@xiaoxiang781216 xiaoxiang781216 merged commit d186c1c into apache:master Oct 8, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Board support Board support issues Area: OS Components OS Components issues Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Regression when building with C++ toolchain enabled - broken locale
2 participants