Code improvements. #881
Open
Code improvements. #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elharo
reviewed
Sep 26, 2023
| .as("Daemon registry size should be " + size) | ||
| .isEqualTo(size); | ||
| Assertions.assertThat(registry.getAll()) | ||
| .as("Daemon registry size should be %d actually containing:(%s)", size, registry.getAll()) |
There was a problem hiding this comment.
not sure what "actually containing" means here. It's a tad awkward phrasing. Is this a UI message somewhere or just a test failure message?
gnodet
reviewed
Sep 27, 2023
| @@ -69,6 +73,11 @@ | |||
| public class DaemonConnector { | |||
|
|
|||
| private static final Logger LOGGER = LoggerFactory.getLogger(DaemonConnector.class); | |||
| private static final Function<DaemonInfo, Boolean> daemonIsIdle = di -> di.getState() == DaemonState.Idle; | |||
There was a problem hiding this comment.
Why not using method if we don't want to inline those methods ?
| @@ -194,6 +203,7 @@ private String handleStopEvents( | |||
| .collect(Collectors.groupingBy(DaemonStopEvent::getDaemonId, Collectors.minBy(this::compare))) | |||
| .values() | |||
| .stream() | |||
| .filter(Optional::isPresent) | |||
There was a problem hiding this comment.
I know IntelliJ prints a warning 'Optional::get' without 'isPresent()' check, but I think this is not a possible case : the groupingBy would not create a key if there's no value, so minBy will always return a non empty Optional.
| } | ||
| } | ||
| String jvmArgs = Objects.toString(parameters.jvmArgs(), ""); | ||
| args.addAll(Stream.of(jvmArgs.split(" ")).filter(nonEmpty).collect(Collectors.toList())); |
There was a problem hiding this comment.
Stream.of(jvmArgs.split(" ")).filter(nonEmpty).forEach(args::add) ? to avoid the toList step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.