-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding sort option for build-classpath #188
base: master
Are you sure you want to change the base?
Conversation
What is the benefit? The same request keeps popping up with Tomcat and the classpath does not rely on order. |
@michael-o well you should consider these points:
I'm not 100% sure if we need more flexibility on the ordering but not sorting the output is quite useless for any pipeline relying on the classpath dump (it is fine for other use cases) so hope we can find a way to sort somehow whatever the order is. Hope it makes sense. |
For debug purposes I understand that a canonization makes sense, but bit for the actual class path. That should always work. |
Classpath is a sorted list in the jvm so order is important for classes and resources. Custom classloaders are unrelated to the classpath and dont have to respect that even if all "true" urlclassloaders will. But here we speak of classpath so order is a thing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For new feature jira issue is appreciated.
/** | ||
* Should the classpath be lexicographically sorted. | ||
*/ | ||
@Parameter( property = "mdep.sortClasspath", defaultValue = "false" ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@since
tag is missing
* Should the classpath be lexicographically sorted. | ||
*/ | ||
@Parameter( property = "mdep.sortClasspath", defaultValue = "false" ) | ||
private boolean sortClasspath = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
false is default value, initialization is redundant
Ordered != sorted. Where is the sort? Show me! |
For now it is a proposal since jira status is quite weird regarding that but I fail to see how to have a deterministic build without such an option so proposing a solution and will create tickets if there is an agreement on the solution.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MDEP-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MDEP-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.