[incubator-kie-issues-1131] test migration from V7 to code generation-36

[Abhitocode]

Few tests within jbpm-tests are disabled as on-exit is not supported. Check if they can be enabled and converted.

Reference issue link: https://issues.redhat.com/browse/KOGITO-2067

Below are the tests:
(https://github.com/apache/incubator-kie-kogito-runtimes/tree/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2)

Below tests within IntermediateEventTest cannot be migrated as due to kie session not working in kogito
testDynamicCatchEventSignalWithVariableUpdated
testDynamicCatchEventSignalWithVariableUpdatedBroadcastSignal

Below tests within FlowTest fail when tried to enable and run in original v7 format,
testMultiInstanceLoopCharacteristicsTaskWithOutput
testMultiInstanceLoopCharacteristicsTaskWithOutputCompletionCondition
testMultiInstanceLoopCharacteristicsTaskWithOutputCompletionCondition2

Note: work in progress

[kie-ci3]

PR job #4 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3682 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3682/4/display/redirect

Test results:

• PASSED: 3325
• FAILED: 3

Those are the test failures:

org.jbpm.bpmn2.IntermediateEventTest.testTimerBoundaryEventInterrupting

expected: 2
but was: 1

org.jbpm.bpmn2.IntermediateEventTest.testIntermediateCatchEventTimerDuration

expected: 2
but was: 1

org.jbpm.bpmn2.IntermediateEventTest.testEventBasedSplit2

expected: 2
but was: 1

[martinweiler]

@Abhitocode re: How can we assert this, what changes are made to child process instances after completing parent process.

Wouldn't this not just be an issue of repeating this assert?

        List<ProcessInstance<DynamicSignalChildModel>> childInstances = childProcessDefinition.instances().stream().toList();
        assertThat(childInstances).hasSize(3);
        childInstances.forEach(instance -> assertThat(instance.status()).isEqualTo(ProcessInstance.STATE_ACTIVE));

In this test, the parent/child sub-process relation is defined as independent, so the child instances should remain active even though the parent has finished.

What about the tests in FlowTest - are you going to add them to this PR as well?

[Abhitocode]

yes will be adding the flow tests

[Abhitocode]

Below tests within FlowTest fail when tried to enable and run in original v7 format,

testMultiInstanceLoopCharacteristicsTaskWithOutput

testMultiInstanceLoopCharacteristicsTaskWithOutputCompletionCondition

testMultiInstanceLoopCharacteristicsTaskWithOutputCompletionCondition2