fix(dist): add license for swagger-ui & reset use stage to false in ci yml #2706
+31
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2706 +/- ##
============================================
- Coverage 46.98% 46.71% -0.27%
+ Complexity 998 823 -175
============================================
Files 745 745
Lines 60060 60060
Branches 7669 7669
============================================
- Hits 28220 28060 -160
- Misses 29012 29183 +171
+ Partials 2828 2817 -11 ☔ View full report in Codecov by Sentry. |
imbajin
reviewed
Dec 16, 2024
There was a problem hiding this comment.
maybe we should disable the 'stage' param in this PR
Also, mark a TODO for using common/rpc dependency directly
There was a problem hiding this comment.
Also, mark a TODO for using common/rpc dependency directly
where to mark?
There was a problem hiding this comment.
Also, mark a TODO for using common/rpc dependency directly
where to mark?
Using the stage param of the server-ci.yml (one is enough) + usage in the pom.xml (common/rpc)
dosubot
bot
added
size:S
dosubot
bot
added
size:M
VGalaxies
force-pushed
the
swagger-ui-license
branch
from
17f70f0 to
a147bb8
Compare
VGalaxies
changed the title
imbajin
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixup #2687
cound not found licenses declared in dist, see swagger-api/swagger-ui#8317