feat: add TZ option and remote timezone option #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Hu <[email protected]>
matrixji
reviewed
Apr 17, 2023
| | service.ingress.tlsSecretName | The secret name for tls's certificate for https | "" | | ||
| | service.ingress.httpPort | The http port for ingress | 80 | | ||
| | service.ingress.httpsPort | The https port for ingress | 443 | | ||
| | option.TZ | The timezone | Asia/Shanghai | |
There was a problem hiding this comment.
That's great. just one discussion: do we need to use UTC as our default timezone?
There was a problem hiding this comment.
@klesh @warren830 What's your opinion?
There was a problem hiding this comment.
UTC has a special meaning for developers.
It would be better to choose a neutral timezone to make it clear that it should be set by users to their own timezone.
I suggest that we use America/Cayman as the placeholder
|
solved by #151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TZ option and remote timezone option