IGNITE-21558 Sql. Remove ExecutionContext dependency from ExpressionFactory #4959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korlov42
force-pushed
the
ignite-21558
branch
3 times, most recently
from
7f1a200 to
7f0ec91
Compare
korlov42
force-pushed
the
ignite-21558
branch
from
7f0ec91 to
0cb2e07
Compare
AMashenkov
reviewed
Dec 24, 2024
| @@ -267,11 +265,13 @@ private final class AccumulatorWrapperImpl implements AccumulatorWrapper<RowT> { | |||
| private final boolean distinct; | |||
|
|
|||
| AccumulatorWrapperImpl( | |||
| RowHandler<RowT> handler, | |||
There was a problem hiding this comment.
If captured context is no longer used, can this class be static?
AMashenkov
approved these changes
Dec 24, 2024
xtern
approved these changes
Dec 25, 2024
| @@ -57,7 +57,7 @@ | |||
| * AccumulatorsFactory. | |||
| * TODO Documentation https://issues.apache.org/jira/browse/IGNITE-15859 | |||
| */ | |||
| public class AccumulatorsFactory<RowT> implements Supplier<List<AccumulatorWrapper<RowT>>> { | |||
| public class AccumulatorsFactory<RowT> { | |||
There was a problem hiding this comment.
Let's fix javadoc and remove TODO?)
| @@ -142,26 +142,24 @@ private static Function<Object, Object> compileCast(IgniteTypeFactory typeFactor | |||
| * TODO Documentation https://issues.apache.org/jira/browse/IGNITE-15859 | |||
| */ | |||
| public AccumulatorsFactory( | |||
| ExecutionContext<RowT> ctx, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-21558
To be sure this patch doesn't affect performance, I've run a few benchmarks. Results as follow:
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes