IGNITE-23747 Support timeouts for RO transactions #4902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Timeouts for RO transactions are supported * Data availability time is used as a default RO transaction timeout * After the timeout expires, an RO transaction gets aborted; we rely on existing cleanup mechanism to close remote cursors of this transaction * RO transaction is guaranteed to not be aborted automatically until its timeout expires, but it might live longer than its timeout * TxManager API has been revamped to make distinction between implicit and explicit transaction initiation more visible
rpuch
force-pushed
the
ignite-23747
branch
3 times, most recently
from
f5fc02f to
3765ce4
Compare
ptupitsyn
reviewed
Dec 16, 2024
ptupitsyn
reviewed
Dec 16, 2024
sashapolo
reviewed
Dec 16, 2024
...core/src/testFixtures/java/org/apache/ignite/internal/testframework/CommonTestScheduler.java
Show resolved
Hide resolved
isapego
approved these changes
Dec 16, 2024
| @@ -433,6 +433,7 @@ void sql_connection::transaction_start() { | |||
| network::data_buffer_owning response = | |||
| sync_request(protocol::client_operation::TX_BEGIN, [&](protocol::writer &writer) { | |||
| writer.write_bool(false); // read_only. | |||
| writer.write((std::int64_t) 0); // timeoutMillis. | |||
There was a problem hiding this comment.
Suggested change
| writer.write((std::int64_t) 0); // timeoutMillis. | |
| writer.write<std::int64_t>(0); // timeoutMillis. |
| @@ -57,6 +57,7 @@ class transactions_impl { | |||
| IGNITE_API void begin_async(ignite_callback<transaction> callback) { | |||
| auto writer_func = [this](protocol::writer &writer) { | |||
| writer.write_bool(false); // readOnly. | |||
| writer.write((std::int64_t) 0); // timeoutMillis. | |||
There was a problem hiding this comment.
Suggested change
| writer.write((std::int64_t) 0); // timeoutMillis. | |
| writer.write<std::int64_t>(0); // timeoutMillis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-23747