Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add a new Singleton-pattern-based LRU local cache #2907

Merged
merged 6 commits into from
Dec 27, 2024

Conversation

doveLin0818
Copy link
Contributor

@doveLin0818 doveLin0818 commented Dec 26, 2024

#2898

What's changed?

Each component shares a single local cache instance,all components that previously utilized the local cache, including Redis, SSH, MongoDB, JDBC, JMX, and Kafka client (new), have been successfully validated and integrated into a single cache instance.
image
Each metric has been successfully tested and validated without error,additionally, for the same type of monitoring, I enabled multiple instances for testing purposes, and they were successfully validated as well. such as the two Kafka clients below originate from different IPs
image

Checklist

  • [✅ ] I have read the Contributing Guide
  • [✅] I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

Copy link
Member

@zqr10159 zqr10159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tomsun28 tomsun28 added the good first pull request Good for newcomers label Dec 27, 2024
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tomsun28 tomsun28 added this to the 1.7.0 milestone Dec 27, 2024
@tomsun28 tomsun28 merged commit 126268f into apache:master Dec 27, 2024
3 checks passed
@doveLin0818 doveLin0818 deleted the addLocalCache branch December 27, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first pull request Good for newcomers
Projects
Development

Successfully merging this pull request may close these issues.

[Question] <title>Is it necessary to incorporate a local caching mechanism into the instance creation process?
3 participants