This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
[PageRank] Make one-to-many messaging configurable #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do we have to create ByteArrayVertexIdMessages before adding to MessageStore, would it be possible to fix that instead and then we get benefit on all apps? |
|
A more general solution at #72. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/GIRAPH-1189
The PageRank implementation uses one-to-many messaging to reduce the amount of traffic sent. The corresponding message request (SendWorkerOneMessageToManyRequest) creates ByteArrayVertexIdMessages instances before adding the messages to the Message Store. When the number of messages is big, the creation of this instances can fail.
Adding an option here to enable/disable the use of one-to-many messaging.
Tests: