Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36963][Runtime] Fix wrong context maintain around asyncProcessWithKey #25855

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

Zakelly
Copy link
Contributor

@Zakelly Zakelly commented Dec 25, 2024

What is the purpose of the change

Within asyncProcessWithKey, the key/record context is switched to the one for asynchronous procedure then switched back. However we picked the wrong old context and switched back with the wrong one. This PR fixes that.

Brief change log

  • The asyncProcessWithKey of both related operators.

Verifying this change

This change is a trivial rework without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@fredia
Copy link
Contributor

fredia commented Dec 25, 2024

Thanks for the fix,LGTM.

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 25, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Zakelly
Copy link
Contributor Author

Zakelly commented Dec 26, 2024

@flinkbot run azure

@Zakelly Zakelly merged commit 19bc0b3 into apache:master Dec 26, 2024
@Zakelly Zakelly deleted the f36963 branch December 26, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants