Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-36954][table] Migrate CalcRankTransposeRule to java #25846

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FLINK-36954][table] Migrate CalcRankTransposeRule to java #25846

wants to merge 1 commit into from

Conversation

liuyongvs
Copy link
Contributor

What is the purpose of the change

The PR migrates CalcRankTransposeRule to java

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

liuyongvs
liuyongvs commented Dec 24, 2024
View reviewed changes
...nk-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRexUtil.scala
@@ -399,15 +400,14 @@ object FlinkRexUtil {
* @return
* Return new expression with new field indices.
*/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments: Must remove the "private[flink]" orElse compile exception

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 24, 2024 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@liuyongvs
Copy link
Contributor Author

hi @snuyanzin will you help review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component=TableSQL/Planner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liuyongvs @flinkbot