Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-36948][tests] Remove deprecated FlinkMatchers #25839

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[FLINK-36948][tests] Remove deprecated FlinkMatchers #25839

wants to merge 2 commits into from
+359 −897

Conversation

snuyanzin
Copy link
Contributor

What is the purpose of the change

The PR drops deprecated FlinkMatchers and replaces all the occurences with usage of FlinkAssertions or other alternatives

Brief change log

all the tests using FlinkMatchers

Verifying this change

the change is in tests itself

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): ( no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no)
  • The S3 file system connector: ( no )

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable )

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 22, 2024 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

liuyongvs
liuyongvs approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@liuyongvs liuyongvs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 @snuyanzin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuyongvs liuyongvs liuyongvs approved these changes

Assignees
No one assigned
Labels
component=Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snuyanzin @flinkbot @liuyongvs