Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36946][Metrics] Optimize sink operator name truncate #25832

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Tartarus0zm
Copy link
Contributor

What is the purpose of the change

Avoid truncation of the Writer/Committer keyword.

Brief change log

  • add MetricUtil#truncateOperatorName to optimize Operator name

Verifying this change

  • SinkMetricsITCase#testMetrics

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 20, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@1996fanrui 1996fanrui self-assigned this Dec 20, 2024
Copy link
Member

@1996fanrui 1996fanrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tartarus0zm for the optimization!

LGTM assuming CI is green.

Copy link
Contributor

@davidradl davidradl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@Tartarus0zm
Copy link
Contributor Author

see comments

thanks for your review, I'll update the commit to addressing your concerns.

@Tartarus0zm
Copy link
Contributor Author

@1996fanrui @davidradl hi, I has updated the commit, take a look again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants