Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3402] Improve Trace class #4987

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zzzk1
Copy link

@zzzk1 zzzk1 commented Jun 10, 2024

Fixes #3402

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Pil0tXia
Pil0tXia previously approved these changes Jun 10, 2024
Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pil0tXia
Copy link
Member

Please check CI failure~

@Pil0tXia Pil0tXia added the waiting for contributor PR is awaiting the contributor's response to the review for further evaluation. label Jun 12, 2024
@Pil0tXia
Copy link
Member

Based on our discussion in #3632, the review comment at #3632 (review) pointed out that the original issue is redundant and invalid. Thank you very much for your contribution. Please feel free to select other valuable issues to work on.

@Pil0tXia Pil0tXia dismissed their stale review June 12, 2024 23:42

issue invalid

@Pil0tXia Pil0tXia added invalid This doesn't seem right and removed waiting for contributor PR is awaiting the contributor's response to the review for further evaluation. labels Jun 12, 2024
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added the Stale label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] "getExtension()" can return null.[Trace]
2 participants