-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling PPC64le support for apache/cxf #1787
base: main
Are you sure you want to change the base?
Conversation
@@ -91,7 +91,7 @@ public void testIsCertChainValid() throws CertificateException { | |||
validator.isCertificateChainValid(Arrays.asList(certificateRoot))); | |||
Assert.assertTrue("wss40rev should not be valid", | |||
!validator.isCertificateChainValid(Arrays.asList(certificateWss40Rev))); | |||
Assert.assertTrue("wss40 should be valid", | |||
Assert.assertTrue("wss40 should not be valid", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanskruti1098 Please explain this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask which JDK for PPCLE64 are you building with?
IIRC RedHat openjdk 17 had a build issue with x509 test case... Temurin on PPC64LE builds clean.
Hi @jgoodyear @reta we used JDK17 Temurin distribution for PPC64LE |
I was able to build CXF main from latest source with Temurin 17.
Here is my build tool chain:
And here is my OS/Hardware level:
Can you verify your local environment has Maven 3.9.6 and Temurin jdk-17.0.10+7 for PPC64LE? |
Hi @jgoodyear @reta we have tested the changes on Linux powervm5 5.15.0-102-generic machine. I am attaching logs for the same. Request to review the file and merge PR |
Hi @sanskruti1098 , The logs show the code pulling Apache CXF 4.0.4 which did have issues building, please update to Apache CXF 4.0.5. Adding here my laboratory log notes: |
Ok @jgoodyear |
Hi @reta to enable PPC64le support for apache/cxf request to review and merge it.