Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use https urls in tests and README #1016

Merged
merged 2 commits into from
Sep 7, 2023
Merged

chore: use https urls in tests and README #1016

merged 2 commits into from
Sep 7, 2023

Conversation

jcesarmobile
Copy link
Member

new cordova apps don't allow http connections by default, so the examples will not work, also it's recommended to use https, so changed the README examples and tests to use https urls.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcesarmobile jcesarmobile reopened this Aug 29, 2023
@jcesarmobile jcesarmobile merged commit 178f2d3 into master Sep 7, 2023
22 of 30 checks passed
@jcesarmobile jcesarmobile deleted the use-https branch September 7, 2023 21:36
pesi-hgc pushed a commit to pesi-hgc/cordova-plugin-inappbrowser-transparent that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants