Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #VFS-834: Updated to avoid prematurely closing file objects. #383

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fixes #VFS-834: Updated to avoid prematurely closing file objects. #383

wants to merge 4 commits into from

Conversation

ivakegg
Copy link
Contributor

@ivakegg ivakegg commented Mar 23, 2023

No description provided.

@ivakegg
Copy link
Contributor Author

ivakegg commented Mar 23, 2023

Working on a test case that demonstrates the issue...

@garydgregory
Copy link
Member

This use case will require careful study because VFS is not built for multi-threading, and in general, getting a list of URLs should not permanently allocate resources.

@ivakegg
Copy link
Contributor Author

ivakegg commented Mar 24, 2023 •
edited
Loading

@garydgregory This is not a multi-threading issue. This is an issue where multiple resources are loaded for the same file in the SAME thread. Then the input stream of one is closed before the other is read. Apparently this can happen with spring when loading a context.

@ivakegg ivakegg force-pushed the bugfix/prematureClose branch from b2f9b50 to 7923cac Compare April 30, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garydgregory garydgregory garydgregory left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivakegg @garydgregory