Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ctrl+Enter command on Start Instance dialog #9743

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lucas-a-martins
Copy link
Contributor

@lucas-a-martins lucas-a-martins commented Sep 27, 2024

Description

This PR fixes the bug presented in the issue #9668, where the Start instance dialog in the UI does not respond to the Ctrl+Enter command.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

I tested by using the Ctrl+Enter command when starting a VM in the instance list view and the VM details view. Worked as intended in both cases.

@JoaoJandre
Copy link
Contributor

@lucas-a-martins could you add a proper PR description and test description?

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.78%. Comparing base (21d107c) to head (3e714d9).
Report is 14 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9743      +/-   ##
============================================
- Coverage     15.81%   15.78%   -0.03%     
- Complexity    12551    12552       +1     
============================================
  Files          5625     5625              
  Lines        491921   491963      +42     
  Branches      60594    63690    +3096     
============================================
- Hits          77802    77668     -134     
- Misses       405802   405835      +33     
- Partials       8317     8460     +143     
Flag Coverage Δ
uitests 4.03% <ø> (-0.45%) ⬇️
unittests 16.60% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucas-a-martins
Copy link
Contributor Author

@lucas-a-martins could you add a proper PR description and test description?

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants