Save systemvm template details for cpvm, ssvm and vr's. #9721

BartJM · 2024-09-23T10:06:22Z

Description

This PR adds saving systemvm template settings to the user_vm_details table. Allows systemvms to start with details specified in the systemvm template settings.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Change systemvm template settings to add iothreads and io.policy.
Recreate ssvm, cpvm and vr and verified the details are in the db and the vms are running with the change.

Ran on a ubuntu 20.04 manager, 22.04 kvm host testing env and mbx kvm centos8 env.

How did you try to break this feature and the system with this change?

boring-cyborg · 2024-09-23T10:06:27Z

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
Be sure to read the CloudStack Coding Conventions.
Apache CloudStack is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: [email protected] (https://cloudstack.apache.org/mailing-lists.html)
Slack: https://apachecloudstack.slack.com/

engine/schema/src/main/java/com/cloud/vm/dao/ConsoleProxyDaoImpl.java

engine/schema/src/main/java/com/cloud/vm/dao/UserVmDetailsDaoImpl.java

codecov · 2024-09-23T14:21:27Z

Codecov Report

Attention: Patch coverage is 5.55556% with 34 lines in your changes missing coverage. Please review.

Project coverage is 15.78%. Comparing base (bf2cede) to head (e331976).

Files with missing lines	Patch %	Lines
...in/java/com/cloud/vm/dao/UserVmDetailsDaoImpl.java	0.00%	15 Missing ⚠️
...om/cloud/consoleproxy/ConsoleProxyManagerImpl.java	0.00%	4 Missing ⚠️
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java	0.00%	3 Missing ⚠️
...va/com/cloud/network/router/NetworkHelperImpl.java	0.00%	3 Missing ⚠️
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	40.00%	3 Missing ⚠️
.../secondarystorage/SecondaryStorageManagerImpl.java	0.00%	3 Missing ⚠️
...n/java/com/cloud/capacity/CapacityManagerImpl.java	0.00%	2 Missing ⚠️
...om/cloud/network/element/VirtualRouterElement.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##               main    #9721     +/-   ##
===========================================
  Coverage     15.78%   15.78%             
- Complexity    12550    12552      +2     
===========================================
  Files          5625     5625             
  Lines        491958   491968     +10     
  Branches      60504    61727   +1223     
===========================================
+ Hits          77663    77673     +10     
+ Misses       405836   405834      -2     
- Partials       8459     8461      +2

Flag	Coverage Δ
uitests	`4.03% <ø> (ø)`
unittests	`16.60% <5.55%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

weizhouapache

code lgtm

not tested yet

engine/schema/src/main/java/com/cloud/vm/dao/UserVmDetailsDaoImpl.java

weizhouapache · 2024-09-24T07:44:33Z

@blueorangutan package

blueorangutan · 2024-09-24T07:46:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-24T08:47:29Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11190

DaanHoogland

nice thanks @BartJM CLGTM

DaanHoogland · 2024-09-27T09:39:04Z

@blueorangutan package

blueorangutan · 2024-09-27T09:40:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

BartJM · 2024-09-27T09:45:01Z

With the new changes also tested the following on mbx centos8 kvm for user vms. All changes were reflected in the database as expected.

Create a vm with ssh key,
Create password enabled vm with ssh key.
Reset ssh key and password.
Set iothreads enabled and io.policy to storage_specific.
Create a vm with custom offering, change the custom values and change offering to fixed
Change vm with fixed offering to custom offering

blueorangutan · 2024-09-27T10:59:43Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11217

DaanHoogland · 2024-09-27T11:56:07Z

@blueorangutan test

blueorangutan · 2024-09-27T11:58:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-09-28T06:59:13Z

[SF] Trillian test result (tid-11565)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 66133 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9721-t11565-kvm-ol8.zip
Smoke tests completed. 138 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_create_iso_with_checksum_md5	`Error`	66.48	test_iso.py
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py
test_disable_oobm_ha_state_ineligible	`Error`	288.31	test_hostha_kvm.py
test_hostha_configure_default_driver	`Error`	77.00	test_hostha_kvm.py
test_hostha_enable_ha_when_host_disabled	`Error`	87.68	test_hostha_kvm.py
test_hostha_enable_ha_when_host_disconected	`Error`	156.97	test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	151.03	test_hostha_kvm.py
test_hostha_kvm_host_degraded	`Error`	76.92	test_hostha_kvm.py
test_hostha_kvm_host_fencing	`Error`	35.70	test_hostha_kvm.py
test_hostha_kvm_host_recovering	`Error`	34.50	test_hostha_kvm.py
test_remove_ha_provider_not_possible	`Error`	37.59	test_hostha_kvm.py

DaanHoogland · 2024-09-30T13:28:22Z

I cannot relate any of the errors to the code (yet) trying insanity first.

DaanHoogland · 2024-09-30T13:28:45Z

@blueorangutan package

blueorangutan · 2024-09-30T13:30:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-30T14:46:19Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11243

DaanHoogland · 2024-09-30T15:10:19Z

@blueorangutan test

blueorangutan · 2024-09-30T15:12:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-10-01T05:45:36Z

[SF] Trillian test result (tid-11580)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 50195 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9721-t11580-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

boring-cyborg bot added component:networking component:secondary-storage component:ssvm labels Sep 23, 2024

weizhouapache reviewed Sep 23, 2024

View reviewed changes

engine/schema/src/main/java/com/cloud/vm/dao/ConsoleProxyDaoImpl.java Outdated Show resolved Hide resolved

DaanHoogland reviewed Sep 23, 2024

View reviewed changes

engine/schema/src/main/java/com/cloud/vm/dao/UserVmDetailsDaoImpl.java Show resolved Hide resolved

weizhouapache approved these changes Sep 24, 2024

View reviewed changes

engine/schema/src/main/java/com/cloud/vm/dao/UserVmDetailsDaoImpl.java Outdated Show resolved Hide resolved

engine/schema/src/main/java/com/cloud/vm/dao/UserVmDetailsDaoImpl.java Show resolved Hide resolved

BartJM added 3 commits September 27, 2024 11:28

Save systemvm template details for cpvm, ssvm and vr's.

a1d861d

Move saveDetails method to UserVmDetailsDaoImpl

b76e698

Move all other saveDetails to use the UserVmDetailsDaoImpl

e331976

BartJM force-pushed the systemvm-save-template-details branch from 9d3550d to e331976 Compare September 27, 2024 09:30

boring-cyborg bot added component:compute component:orchestration labels Sep 27, 2024

DaanHoogland approved these changes Sep 27, 2024

View reviewed changes

DaanHoogland added the status:needs-testing label Sep 27, 2024

DaanHoogland added this to the 4.20.1.0 milestone Oct 1, 2024

DaanHoogland added the type:improvement label Oct 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Save systemvm template details for cpvm, ssvm and vr's. #9721

Save systemvm template details for cpvm, ssvm and vr's. #9721

BartJM commented Sep 23, 2024

boring-cyborg bot commented Sep 23, 2024

codecov bot commented Sep 23, 2024 •

edited

Loading

weizhouapache left a comment

weizhouapache commented Sep 24, 2024

blueorangutan commented Sep 24, 2024

blueorangutan commented Sep 24, 2024

DaanHoogland left a comment

DaanHoogland commented Sep 27, 2024

blueorangutan commented Sep 27, 2024

BartJM commented Sep 27, 2024

blueorangutan commented Sep 27, 2024

DaanHoogland commented Sep 27, 2024

blueorangutan commented Sep 27, 2024

blueorangutan commented Sep 28, 2024

DaanHoogland commented Sep 30, 2024

DaanHoogland commented Sep 30, 2024

blueorangutan commented Sep 30, 2024

blueorangutan commented Sep 30, 2024

DaanHoogland commented Sep 30, 2024

blueorangutan commented Sep 30, 2024

blueorangutan commented Oct 1, 2024

Save systemvm template details for cpvm, ssvm and vr's. #9721

Are you sure you want to change the base?

Save systemvm template details for cpvm, ssvm and vr's. #9721

Conversation

BartJM commented Sep 23, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

boring-cyborg bot commented Sep 23, 2024

codecov bot commented Sep 23, 2024 • edited Loading

Codecov Report

weizhouapache left a comment

Choose a reason for hiding this comment

weizhouapache commented Sep 24, 2024

blueorangutan commented Sep 24, 2024

blueorangutan commented Sep 24, 2024

DaanHoogland left a comment

Choose a reason for hiding this comment

DaanHoogland commented Sep 27, 2024

blueorangutan commented Sep 27, 2024

BartJM commented Sep 27, 2024

blueorangutan commented Sep 27, 2024

DaanHoogland commented Sep 27, 2024

blueorangutan commented Sep 27, 2024

blueorangutan commented Sep 28, 2024

DaanHoogland commented Sep 30, 2024

DaanHoogland commented Sep 30, 2024

blueorangutan commented Sep 30, 2024

blueorangutan commented Sep 30, 2024

DaanHoogland commented Sep 30, 2024

blueorangutan commented Sep 30, 2024

blueorangutan commented Oct 1, 2024

codecov bot commented Sep 23, 2024 •

edited

Loading