-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Forgot password #9509
Feature: Forgot password #9509
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9509 +/- ##
===========================================
Coverage 15.76% 15.76%
- Complexity 12510 12524 +14
===========================================
Files 5621 5627 +6
Lines 491469 491884 +415
Branches 62967 60293 -2674
===========================================
+ Hits 77460 77544 +84
- Misses 405553 405878 +325
- Partials 8456 8462 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f24c534
to
61f676c
Compare
092390b
to
0fc1cea
Compare
0fc1cea
to
c665a2f
Compare
c665a2f
to
b0bf666
Compare
b0bf666
to
51a721c
Compare
51a721c
to
a5df0af
Compare
@blueorangutan package |
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10631 |
@blueorangutan test |
@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
[SF] Trillian test result (tid-11068)
|
@blueorangutan package |
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11028 |
@JoaoJandre This feature is behind a flag to enable or disable the password recovery workflow. By default, it's disabled. Can we include this PR in 4.20 release as well? |
@blueorangutan test |
@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
@vishesh92 same as #9633 (comment) :) |
[SF] Trillian Build Failed (tid-11418) |
[SF] Trillian Build Failed (tid-11420) |
@blueorangutan test |
@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
[SF] Trillian Build Failed (tid-11421) |
@blueorangutan package |
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11050 |
@blueorangutan test |
@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
@blueorangutan help |
@borisstoyanov [SL] I understand these words: "help", "hello", "thanks", "package", "test" Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'shwstppr', 'vishesh92', 'Pearl1594', 'harikrishna-patnala', 'nvazquez', 'DaanHoogland', 'weizhouapache', 'borisstoyanov', 'vladimirpetrov', 'kiranchavala', 'andrijapanicsb', 'NuxRo', 'rajujith', 'alexandremattioli', 'sureshanaparti', 'abh1sar'] |
[SF] Trillian test result (tid-11422)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, manually tested it.
@JoaoJandre @DaanHoogland are we accepting feature PRs now? This is ready for merging and has been reviewed & manually tested. |
@borisstoyanov Could you share what tests were done? |
sure @JoaoJandre, both positive/negative scenarios, as well with different sub-domains accounts. Also verified the token cannot be used to change other users pass and basic user discovery prevention where prompts a generic response either having matching user or not. Also there were some polishing comments for the email, it now uses html format and there is a text with hyperlink rather than raw hyperlink as before. I didn't see any issues, have you experienced any? |
@borisstoyanov I have not tested the PR. But it is generally good practice to list the tests done and their steps. Like the PR description does. |
* Feature: Forgot password * Address comments * fixups * Make forgot password disabled by default * Apply suggestions from code review * Address comments
Docs PR: apache/cloudstack-documentation#432
Description
This PR adds the functionality to reset password for a user by email.
8 Global settings:
password.reset.ttl
password.reset.email.sender
null
password.reset.smtp.host
null
password.reset.smtp.port
password.reset.smtp.useAuth
False
password.reset.smtp.username
null
password.reset.smtp.password
null
password.reset.mail.template
2 new APIs:
Params: username, domain
Details: Sends an email to the user with a token which can be used to reset the password using resetPassword command.
Params: username, domain, token, password
Details: Resets the password for the user using the token generated via forgotPassword command.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
{ACS MS}/user/resetPassword
on the UI.How did you try to break this feature and the system with this change?