utils: cleanup MacAddress and MacAddressTest

[rohityadavcloud]

Cleanup old mac address handling code to use JDK11 lib instead of hacks. Also really strange to see some basic string parsing code was written by hand, replaced with Long.parseValue(str, 16) to convert hex string to long.

Fixes #8174

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[DaanHoogland]

nice cleanup

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 57.14286% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 14.96%. Comparing base (e409c6d) to head (67e5ae4).

Files	Patch %	Lines
.../src/main/java/com/cloud/utils/net/MacAddress.java	57.14%	5 Missing and 7 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #8988      +/-   ##
============================================
- Coverage     14.96%   14.96%   -0.01%     
+ Complexity    10995    10986       -9     
============================================
  Files          5373     5373              
  Lines        468989   468899      -90     
  Branches      61009    60411     -598     
============================================
- Hits          70191    70159      -32     
+ Misses       391019   390971      -48     
+ Partials       7779     7769      -10     

Flag	Coverage Δ
uitests	4.31% <ø> (ø)
unittests	15.66% <57.14%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9441

[rohityadavcloud]

@blueorangutan test

[weizhouapache]

@rohityadavcloud
I copied the code and run it locally

• on mgmt server (with only 1 interface), the macAddressInLong value is same as previous legacy code. that is good

macAddressInLong = 32989023043991

mysql> select msid from mshost where state='Up';
+----------------+
| msid           |
+----------------+
| 32989023043991 |
+----------------+
1 row in set (0.00 sec)

• run it on kvm host

network.getName() = vnet125
network.getName() = vnet150
network.getName() = vnet110
network.getName() = vnet127
network.getName() = vnet111
network.getName() = vnet124
network.getName() = vnet148
network.getName() = vnet78
network.getName() = vnet145
network.getName() = vnet118
network.getName() = vnet122
network.getName() = vnet116
network.getName() = vnet147
network.getName() = vnet117
network.getName() = vnet123
network.getName() = vnet80
network.getName() = vnet79
network.getName() = vnet146
network.getName() = vnet149
network.getName() = vnet112
network.getName() = vnet126
network.getName() = vnet131
network.getName() = cloud0
network.getName() = cloudbr1
network.getName() = cloudbr0
network.getName() = lo

my suggestion is

• reverse the elements in the return of NetworkInterface.getNetworkInterfaces
• ignore lo interface, so the code will get the mac address of the first non-loopback nic.

[rohityadavcloud]

Thanks @weizhouapache @sureshanaparti I've addressed the review comments.

@blueorangutan package

[blueorangutan]

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9451

[rohityadavcloud]

@blueorangutan test

[blueorangutan]

@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-10064)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47052 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8988-t10064-kvm-centos7.zip
Smoke tests completed. 128 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	Error	405.75	test_events_resource.py
test_01_redundant_vpc_site2site_vpn	Failure	406.81	test_vpc_vpn.py

[shwstppr]

LGTM

[weizhouapache]

code lgtm

deployed it on an existing environment, there is no new management server added to mshost table