Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling, word case, duplicate words in code comments only #8987

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

jbampton
Copy link
Member

Description

This PR cleans up the docs. Only touched code comments.

A small PR and perhaps we can merge more quickly.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Apr 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.26%. Comparing base (6e823b2) to head (eef98c5).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #8987   +/-   ##
=====================================
  Coverage   4.26%   4.26%           
=====================================
  Files        363     363           
  Lines      29556   29556           
  Branches    5188    5188           
=====================================
  Hits        1262    1262           
  Misses     28152   28152           
  Partials     142     142           
Flag Coverage Δ
uitests 4.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbampton
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9440

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jbampton
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9454

@DaanHoogland
Copy link
Contributor

are you still working on this @jbampton ?

@jbampton
Copy link
Member Author

Ready for review @DaanHoogland

@DaanHoogland DaanHoogland merged commit db572f4 into apache:main Apr 30, 2024
24 checks passed
@jbampton jbampton deleted the fix-spelling-word-case-duplicates branch April 30, 2024 09:01
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 3, 2024
@DaanHoogland DaanHoogland added this to the 4.20.0.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:integration-test Python Warning... Python code Ahead!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants