Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for delete protection for instances & volumes #433

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Add documentation for delete protection for instances & volumes #433

merged 2 commits into from
Sep 10, 2024

Conversation

vishesh92
Copy link
Member

@vishesh92 vishesh92 commented Sep 4, 2024 •
edited by github-actions bot
Loading

@vishesh92 vishesh92 mentioned this pull request Sep 4, 2024
Merged
9 tasks
@sureshanaparti sureshanaparti changed the title Add documetation for delete protection for instances & volumes Add documentation for delete protection for instances & volumes Sep 5, 2024
@sureshanaparti
Copy link
Contributor

@blueorangutan docbuild

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/433. (QA-JID 258)

@sureshanaparti
Copy link
Contributor

@blueorangutan docbuild

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/433. (QA-JID 259)

@vishesh92
Copy link
Member Author

@blueorangutan docbuild

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/433. (QA-JID 261)

@vishesh92 @sureshanaparti
Apply suggestions from code review
d78a739 
Co-authored-by: Suresh Kumar Anaparti <[email protected]>
@sureshanaparti
Copy link
Contributor

@blueorangutan docbuild

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/433. (QA-JID 263)

sureshanaparti
sureshanaparti approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc lgtm

@rohityadavcloud rohityadavcloud merged commit 8e1292e into apache:main Sep 10, 2024
1 check passed
@rohityadavcloud rohityadavcloud modified the milestone: 4.19.1 Sep 10, 2024
@rohityadavcloud rohityadavcloud added this to the 4.20 milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sureshanaparti sureshanaparti sureshanaparti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.20
Development

Successfully merging this pull request may close these issues.
4 participants
@vishesh92 @sureshanaparti @blueorangutan @rohityadavcloud