Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix orca target list will be disordered when function's return_type i… #813

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wenchaozhang-123
Copy link
Contributor

…s record.

This commit, in orca, we will reassign every TargetEntry's resno by iterating all arguments in function when its return_type is record. As a result, the target list of function scan will be ordered.

Authored-by: Zhang Wenchao [email protected]

Fixes #ISSUE_Number

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


@my-ship-it
Copy link
Contributor

Add test cases?

@wenchaozhang-123 wenchaozhang-123 force-pushed the fix_orca_func branch 2 times, most recently from 78466cf to 36fd69b Compare December 25, 2024 06:23
@wenchaozhang-123 wenchaozhang-123 force-pushed the fix_orca_func branch 4 times, most recently from 60c7a34 to 60185ad Compare December 26, 2024 04:22
jiaqizho
jiaqizho previously approved these changes Dec 26, 2024
…s record.

This commit, in orca, we will reassign every TargetEntry's resno by iterating all
arguments in function when its return_type is record. As a result, the target list
of function scan will be ordered.

Authored-by: Zhang Wenchao [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants