Cherry-pick: COPY FORM doesn't throw out ERROR: extra data after last expected column (7X) #793
+145
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ected column (7X) (#15612) This commit can fix bug reported in [issue 15625] (https://github.com/greenplum-db/gpdb/issues/15625) **Solution：** In pg12.12, there is no function `InitCopyFromDispatchSplit()`, so attr_count must be > 0. In GP7, we may get `[NULL]` in QE when all fields are processed in the QD. So the condition checking should change from `attr_count > 0` to `attr_count >= 0`. But before it, `attr_count = list_length(attnumlist);`, we can ensure that `attr_count >= 0` consistently, so delete this bug-related condition `attr_count > 0`. Signed-off-by: Yongtao Huang <[email protected]> Co-authored-by: Xiaoxiao He <[email protected]>
Part of copy.c is split into copyfrom.c and copyto.c in PG-14 Signed-off-by: Yongtao Huang <[email protected]>
Commit 5cae067e41e introduces test file under data dir for copy case. That will generate untracked file after regression tests. Untracked files:
```
(use "git add <file>..." to include in what will be committed)
src/test/regress/data/copy_no_cols.data
nothing added to commit but untracked files present (use "git add" to track)
```
Move temp date files to reuslts dir to avoid that.
|
Critical fix cherry-pick! Your efforts are greatly appreciated. |
hyongtao-db
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long log:
In pg-12, there is no function
InitCopyFromDispatchSplit(),so attr_count must be > 0. But in GP7, we may get
[NULL]inQE when all fields are processed in the QD. So the condition
checking should change from
attr_count > 0toattr_count >= 0.But before it,
attr_count = list_length(attnumlist);,we can ensure that
attr_count >= 0consistently,so delete this bug-related condition
attr_count > 0.Due to code refactoring in gp-14, the related code is moved
from
copy.ctocopyfrom.c, so modify the related code incopyfrom.c.