Fix confused print of gp_connections test case. #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When regression succeeds to run gp_connections case, some printed info are confused: ============== running regression test queries ============== test gp_connections ... ok (test process exited with exit code 2) While the test passed, but the message seems to tell us that the process exit unexpectedly. The case is designed to exit with code 2 which is expected: failed to connect a primary db. However the message may make developers confused and try to find something wrong but actually not. And after a failed connect, the script will exit, there is no chance to do something to make amends. Hacked in pg_regress to ignore gp_connections exit code info. ============== running regression test queries ============== test gp_connections ... ok 2500 ms This fix doesn't have an impact on test case behavior: if there is diffs between sql and expected files, the case failed as expected. Authored-by: Zhang Mingli [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I, along with other developers I’ve heard from, occasionally find ourselves puzzled: the test
gp_connectionsclearly succeeded, but the printed results seem somewhat incorrectWhen regression succeeds to run gp_connections case, some printed info are confused:
While the test passed, but the message seems to tell us that the process exit unexpectedly.
I dig into this and found: the case is designed to exit with code 2 which is expected: failed to connect a primary db.
However the message may make developers confused and try to find something wrong but actually not.
And after a failed connect, the script will exit, there is no chance to do something to make amends.
Hacked in pg_regress to ignore gp_connections exit code info.
This fix doesn't have an impact on test case behavior: if there is diffs between sql and expected files, the case failed as expected.
Authored-by: Zhang Mingli [email protected]
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions