Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CELEBORN-1804] Shuffle environment metrics of RemoteShuffleEnvironment should use Shuffle.Remote metric group #3032

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CELEBORN-1804] Shuffle environment metrics of RemoteShuffleEnvironment should use Shuffle.Remote metric group #3032

wants to merge 1 commit into from

Conversation

SteNicholas
Copy link
Member

@SteNicholas SteNicholas commented Dec 25, 2024 •
edited
Loading

What changes were proposed in this pull request?

Shuffle environment metrics of RemoteShuffleEnvironment should use Shuffle.Remote metric group.

Why are the changes needed?

Shuffle environment metrics of RemoteShuffleEnvironment uses incorrect netty metric group defined as Shuffle.Netty. Therefore, RemoteShuffleEnvironment should use remote metric group like Shuffle.Remote for shuffle environment metrics.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI.

@SteNicholas
Copy link
Member Author

Ping @reswqa, @codenohup, @FMX.

@apache apache deleted a comment from reswqa Dec 25, 2024
@SteNicholas SteNicholas force-pushed the CELEBORN-1804 branch 2 times, most recently from 70dbdb4 to 71151ba Compare December 25, 2024 12:42
@SteNicholas SteNicholas requested a review from reswqa December 25, 2024 12:43
@SteNicholas SteNicholas changed the title [CELEBORN-1804] Task level metric group structure of RemoteShuffleEnvironment should use Shuffle.Remote.<Input|Output>.Buffers [CELEBORN-1804] Shuffle environment metrics of RemoteShuffleEnvironment should use Shuffle.Remote metric group Dec 26, 2024
@SteNicholas SteNicholas requested a review from reswqa December 26, 2024 03:50
@SteNicholas
Copy link
Member Author

@reswqa, @codenohup, RequestedMemoryUsageMetric is introduced in Flink 1.15. Meanwhile, the implementation of RequestedMemoryUsageMetric is different between Flink 1.15 and other version. Therefore, it's blocked by #3029 to move RequestedMemoryUsageMetric to common module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reswqa reswqa Awaiting requested review from reswqa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SteNicholas @reswqa