[CELEBORN-1787] Fix netty memory metrics was not registered when enable memory allocator share #3007
+24
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le memory allocator share
AngersZhuuuu
approved these changes
Dec 19, 2024
| conf.networkAllocatorVerboseMetric(), | ||
| source, | ||
| Collections.emptyMap()); | ||
| } |
There was a problem hiding this comment.
Should remove create NettyMemoryMetrics here
|
I will daft it, we should ensure that in all places where getPooledByteBufAllocator is called, the source passed in is not null. |
pan3793
reviewed
Dec 20, 2024
| poolName = moduleName; | ||
| int index = allocatorsIndex.compute(moduleName, (k, v) -> v == null ? 0 : v + 1); | ||
| if (conf.getCelebornConf().networkMemoryAllocatorAllowCache()) { | ||
| poolName = allowCache ? "netty-shared-cache-pool" : "netty-shared-non-cache-pool"; |
There was a problem hiding this comment.
given it also could be used on the client side, we'd better have celeborn- prefix in the name to distinguish with netty pools created by other components
Suggested change
| poolName = allowCache ? "netty-shared-cache-pool" : "netty-shared-non-cache-pool"; | |
| poolName = allowCache ? "celeborn-netty-shared-cache-pool" : "celeborn-netty-shared-pool"; |
|
how does this affect grafana dashboard? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix netty memory metrics was not registered when enable memory allocator share
Why are the changes needed?
Fix netty memory metrics was not registered when enable memory allocator share
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing uts.