[CELEBORN-1776] Add UT when replica enable and workers randomly shutdown #2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mridulm
reviewed
Dec 20, 2024
| workerKiller(workerKillTime) | ||
| val result1 = ss.sparkContext.parallelize(1 to 800, 100) | ||
| .flatMap(_ => (1 to 15000).iterator.map(num => num)).repartition(100).count() | ||
| assert(result1 == result) |
There was a problem hiding this comment.
There is an inherent risk here that we actually dont end up triggering the behavior we need to test.
Instead, do we want to introduce some delay (for specific partitions) to ensure failures happen while the application is running?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add two UT when replica enable and workers randomly shutdown.
Why are the changes needed?
Test some fail cases.
Does this PR introduce any user-facing change?
How was this patch tested?
existing ut