[CELEBORN-1764][CIP-11] Adding support for TagsQL for filtering workers tags #2980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0nskar
changed the title
FMX
reviewed
Dec 10, 2024
| /** | ||
| * TagsQL uses key/value pair to give your tags more context. | ||
| * | ||
| * The query language supports the following syntax: |
There was a problem hiding this comment.
In what scenarios might you need this functionality?
Can the following rules align with your goal?
tag1,tag2 | tag3,tag4 | tag5,tag6
In the expression above, tag1 and tag2 are combined using a logical AND, just like tag3 and tag4. The results of tag1 AND tag2 and tag3 AND tag4 are combined using a logical OR.
FMX
reviewed
Dec 10, 2024
|
|
||
| private def parseToken(token: String): Node = { | ||
| token match { | ||
| case Pattern(key, condition, values, value) => |
There was a problem hiding this comment.
I would rather not use regex, as there can always be bugs in regex engines that may lead to unexpected outcomes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added support for TagsQL, which uses key/value pair to give workers tags more context.
The TagsQL supports the following syntax:
key:valuekey:!valuekey:{value1,value2}key:!{value1,value2}Example tags expression:
env:production region:{us-east,us-west} env:!sandboxThis tags expression will select all of the workers that have the following tags:
and will ignore all of the workers that have the following tags:
Why are the changes needed?
Current/default supported tags expression is very basic which select the workers with all the mentioned tags. TagsQL will allow more flexibility and extensibility to workers tags.
Does this PR introduce any user-facing change?
NA
How was this patch tested?
UTs