Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-1626] group mapTask #2771

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from
Draft

Conversation

zaynt4606
Copy link
Contributor

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

@zaynt4606 zaynt4606 force-pushed the groupMapTask branch 2 times, most recently from c171c12 to b305f91 Compare October 29, 2024 03:11
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 32.17%. Comparing base (165e914) to head (41fba8d).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
...born/common/protocol/message/ControlMessages.scala 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2771      +/-   ##
==========================================
- Coverage   32.35%   32.17%   -0.17%     
==========================================
  Files         329      329              
  Lines       19511    19697     +186     
  Branches     1752     1774      +22     
==========================================
+ Hits         6311     6336      +25     
- Misses      12855    13015     +160     
- Partials      345      346       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added stale and removed stale labels Dec 12, 2024
@mridulm
Copy link
Contributor

mridulm commented Dec 20, 2024

I dont think this CIP was discussed in the mailing list - was it ? I want to make sure I did not miss the details !
Essentially I am trying to understand how much config tuning would help, what is the space of problems where map side grouping would benefit, and how we can transition from one to the other reasonably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants