Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CASSANDRA-20150 Create snapshot manifest upon loading where it does not exist or enrich it #3751

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

CASSANDRA-20150 Create snapshot manifest upon loading where it does not exist or enrich it #3751

wants to merge 3 commits into from

Conversation

smiklosovic
Copy link
Contributor

Thanks for sending a pull request! Here are some tips if you're new here:

  • Ensure you have added or run the appropriate tests for your PR.
  • Be sure to keep the PR description updated to reflect all changes.
  • Write your PR title to summarize what this PR proposes.
  • If possible, provide a concise example to reproduce the issue for a faster review.
  • Read our contributor guidelines
  • If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:

<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

@smiklosovic smiklosovic force-pushed the CASSANDRA-20150 branch 2 times, most recently from 13b3711 to c7102e8 Compare December 18, 2024 14:25
@smiklosovic
Create manifest upon loading where it does not exist or enrich it
97d0e37 
In 4.0 times, there was no snapshot manifest created. When such
node is upgraded to 5.1, no snapshots would be found, because even
they would be loaded, snapshot's presence is logically determined by the
existence of at least one manifest.json file in any data dir. That
would result in snapshots not being shown e.g. in the output of
nodetool listsnapshots.

The fix consists of creating a manifest in each snapshot directory when not present.

When a manifest.json exists, its older format has not contained created_at field.
When this is detected, we will proceed to enrich such manifest by overwriting it
with a manifest of new format.

patch by Stefan Miklosovic; reviewed by TBD for CASSANDRA-20150
@smiklosovic
DO NOT COMMIT
e25ce93
@smiklosovic
review feedback
2438131
@smiklosovic
Copy link
Contributor Author

@bbotella thanks, everything incorporated

@bbotella
Copy link
Contributor

Thanks! +1 from my end (non-binding)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbotella bbotella bbotella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smiklosovic @bbotella