Cassandra 20118 5.0 #3737
Draft
Cassandra 20118 5.0 #3737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smiklosovic
reviewed
Dec 11, 2024
| * @param transformation transformation function which gets the row from the old table and returns a row for the new table | ||
| */ | ||
| @VisibleForTesting | ||
| static void migrateTable(boolean truncateIfExists, String oldName, String newName, String[] columns, Function<UntypedResultSet.Row, Collection<Object[]>> transformation) |
There was a problem hiding this comment.
@driftx does this method differ from the one in 41 migrator? What about having abstract migrator these two extend and putting that method there so we can reuse?
driftx
force-pushed
the
CASSANDRA-20118-5.0
branch
3 times, most recently
from
13c3d58 to
ce05f91
Compare
driftx
force-pushed
the
CASSANDRA-20118-5.0
branch
from
ce05f91 to
d80c66b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for Stefan