Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem of fetching nodes from discovery naming service #1293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wasphin
Copy link
Member

@wasphin wasphin commented Nov 24, 2020

根据 批量获取实例fetchs, instances 下面有一级 zones.

@zyearn
Copy link
Member

zyearn commented Nov 24, 2020

改这个的背景是什么?在内部discovery返回的instances下面是一个array,是内外版本不一致导致的么

@wasphin
Copy link
Member Author

wasphin commented Nov 24, 2020

改这个的背景是什么?在内部discovery返回的instances下面是一个array,是内外版本不一致导致的么

从 GitHub 上开放的 discovery 返回的 instances 下有一级 zone,项目里 API 文档介绍也是有的,不确定内部接口是什么样的,如果是不一致那应该判断或说明一下。

@wasphin
Copy link
Member Author

wasphin commented Nov 24, 2020

另外如果需要改就再补一下单元测试部分

@wasphin wasphin force-pushed the feature/fix-discovery-fetch-response branch from ea76a66 to f1177dc Compare November 24, 2020 13:34
@zyearn
Copy link
Member

zyearn commented Nov 25, 2020

这个要在discovery issue区确认一下,如果不一样的话,最好在discovery解决(或许是内部版本没及时更新到github上)

@wasphin
Copy link
Member Author

wasphin commented Nov 28, 2020

这个要在discovery issue区确认一下,如果不一样的话,最好在discovery解决(或许是内部版本没及时更新到github上)

bilibili/discovery#70

已经提 issue 了,但是貌似没什么回应,QQ 群也一样,不是很活跃,@zyearn 内部有没有什么其他的沟通渠道?

另外如果 discovery 对外的接口不做更新,brpc 是不是可以通过编译选项之类的对外先保持一致?

@zyearn
Copy link
Member

zyearn commented Nov 29, 2020

不太清楚还有其它的沟通渠道。
最好等等他们回复吧,否则在brpc维护两套代码比较奇怪。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants