Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make plugin hub page plugins icon horizontal center #501

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

foolwc
Copy link
Contributor

@foolwc foolwc commented Aug 23, 2021

Fixes: #484

Changes:

  • make plugin hub page plugins icon horizontal center
  • hide <SidebarContainer/> when screen size less than 1200px

Screenshots of the change:
image
image

@netlify
Copy link

netlify bot commented Aug 23, 2021

✔️ Deploy Preview for apisix ready!

🔨 Explore the source changes: 25f1f27

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix/deploys/612502c4c672e4000776024d

😎 Browse the preview: https://deploy-preview-501--apisix.netlify.app

@juzhiyuan juzhiyuan requested a review from bzp2010 August 23, 2021 14:59
@1502shivam-singh
Copy link
Member

Also, @foolwc nice of you to make this page mobile responsive, wasn't earlier to this.

One thing that I think needs improvement is that long scroll to reach the later section on mobile. We will need to add a system like that in the docs (check this page through mobile-device view, devtools - docs) for jumping across sections or something similar that does this.

But that can be done in some later PR...

@1502shivam-singh
Copy link
Member

image

Might want to check plugin.json

@foolwc
Copy link
Contributor Author

foolwc commented Aug 24, 2021

Also, @foolwc nice of you to make this page mobile responsive, wasn't earlier to this.

One thing that I think needs improvement is that long scroll to reach the later section on mobile. We will need to add a system like that in the docs (check this page through mobile-device view, devtools - docs) for jumping across sections or something similar that does this.

But that can be done in some later PR...

Agreed. We could change the component SideContainer to anchor hyperlinks and jumping between them.
The layout of plugin hub page needs to be optimized to be more responsive.

@liuxiran
Copy link
Contributor

Also, @foolwc nice of you to make this page mobile responsive, wasn't earlier to this.

One thing that I think needs improvement is that long scroll to reach the later section on mobile. We will need to add a system like that in the docs (check this page through mobile-device view, devtools - docs) for jumping across sections or something similar that does this.

But that can be done in some later PR...

create an issue to trace it. Thanks all of you for making the plugin pages more and more sophisticated!

@liuxiran liuxiran requested a review from juzhiyuan August 25, 2021 10:40
@juzhiyuan juzhiyuan merged commit 3d4a82d into apache:master Sep 8, 2021
1502shivam-singh pushed a commit to 1502shivam-singh/apisix-website that referenced this pull request Sep 19, 2021
1502shivam-singh pushed a commit to 1502shivam-singh/apisix-website that referenced this pull request Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature required: place the plugin icon image horizontal center in plugins page
4 participants