Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action button setup for variables list #45205

Merged
merged 8 commits into from
Dec 26, 2024

Conversation

shubhamraj-git
Copy link
Contributor

@shubhamraj-git shubhamraj-git commented Dec 25, 2024

image

Note:

This PR is raised to give the base support to all actions, to avoid dependency, having this will allow to track upcoming PRs for add and delete separately.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Dec 25, 2024
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks.

A few improvement suggestions.

airflow/ui/src/pages/Variables/VariableAction.tsx Outdated Show resolved Hide resolved
airflow/ui/src/pages/Variables/VariableAction.tsx Outdated Show resolved Hide resolved
airflow/ui/src/pages/Variables/Variables.tsx Outdated Show resolved Hide resolved
@shubhamraj-git
Copy link
Contributor Author

shubhamraj-git commented Dec 25, 2024

@pierrejeambrun Also regarding the placement of this button? do we need to follow the leagcy? It was in starting of the row, Should i add there?
But if we want consistency throughout all pages, it should be at end.

@pierrejeambrun
Copy link
Member

@pierrejeambrun Also regarding the placement of this button? do we need to follow the leagcy? It was in starting of the row, Should i add there?
But if we want consistency throughout all pages, it should be at end.

Actions at the end of the row seems fine by me.

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jscheffl jscheffl merged commit 48a72b0 into apache:main Dec 26, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants