Chart: add info that storageClassName can be templated #45176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aakcht
requested review from
dstandish,
jedcunningham and
hussein-awala
as code owners
IlaiGigi
reviewed
Dec 25, 2024
| @@ -1785,7 +1785,7 @@ | |||
| "default": "100Gi" | |||
| }, | |||
| "storageClassName": { | |||
| "description": "If using a custom StorageClass, pass name ref to all StatefulSets here.", | |||
| "description": "If using a custom StorageClass, pass name ref to all StatefulSets here (can be templated).", | |||
There was a problem hiding this comment.
This is used for the storage class of the scheduler as well as you can see in scheduler-deployment.yaml .
@romsharon98 think we should add something about this here?
There was a problem hiding this comment.
Please let me know if you think this should be added here, but I'm not sure it is needed since it can only affect scheduler when using local executor, so when scheduler pod is also a worker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to template
storageClassNameparameter, but for some reason it is not mentioned at https://airflow.apache.org/docs/helm-chart/stable/parameters-ref.html as it is for other parameters that support templating. This small PR fixes it.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.