-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Added example of _push_xcoms_if_necessary to deferring.rst #45158
base: main
Are you sure you want to change the base?
Fix: Added example of _push_xcoms_if_necessary to deferring.rst #45158
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
@tirkarthi @eladkal -> I think you were more involved in #44759 - that one looks nice and good I will have a few nits. |
async def run(self) -> AsyncIterator[TriggerEvent]: | ||
await asyncio.sleep(self.duration.total_seconds()) | ||
if self.end_from_trigger: | ||
task_instance = ... # Get the relevant TaskInstance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I am not sure how to get the task instance here . I am not sure if you can do it automatically ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, let me look into this again, and try to make the necessary changes that @tirkarthi suggested.
I don't think this is the right approach. My comment was that you can set |
@potiuk @tirkarthi I've created a PR with the changes, please do look into it, and let me know if I'm still not able to understand it properly, will make the required changes if needed. |
What is the purpose of this PR?
This PR updates the
deferring.rst
documentation to include an example of the_push_xcoms_if_necessary
method, as suggested in issue #44759.The new content provides guidance on:
_push_xcoms_if_necessary
with custom triggers.Related Issues
Closes #44759.
Changes Made
deferring.rst
to describe the_push_xcoms_if_necessary
method and its usage.Checklist
Reviewers
Please suggest any further refinements or additional examples if required.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.