Add view_url for DagBundles #45126
Add view_url for DagBundles #45126
Conversation
boring-cyborg
bot
added
the
area:Scheduler
This PR adds view_url to Dagbundles to enable viewing the bundle's version
ephraimbuddy
force-pushed
the
bundle_view_url
branch
from
7bdbe1e to
bcc7524
Compare
| if not version: | ||
| raise AirflowException("Version is required to view the repository") |
There was a problem hiding this comment.
Typing allowing none versions, but having it always raise, feels a bit awkward. Perhaps we just return none in this case?
| if not self._has_version(self.repo, version): | ||
| raise AirflowException(f"Version {version} not found in the repository") |
There was a problem hiding this comment.
Not sure we should even check - we are just building a url, let the other side display a 404.
| if self.repo_url.startswith("git@"): | ||
| parts = self.repo_url.split(":") | ||
| domain = parts[0].replace("git@", "https://") | ||
| repo_path = parts[1].replace(".git", "") | ||
| return f"{domain}/{repo_path}" | ||
| raise ValueError(f"Invalid git SSH URL: {self.repo_url}") |
There was a problem hiding this comment.
| if self.repo_url.startswith("git@"): | |
| parts = self.repo_url.split(":") | |
| domain = parts[0].replace("git@", "https://") | |
| repo_path = parts[1].replace(".git", "") | |
| return f"{domain}/{repo_path}" | |
| raise ValueError(f"Invalid git SSH URL: {self.repo_url}") | |
| if not self.repo_url.startswith("git@"): | |
| raise ValueError(f"Invalid git SSH URL: {self.repo_url}") | |
| parts = self.repo_url.split(":") | |
| domain = parts[0].replace("git@", "https://") | |
| repo_path = parts[1].replace(".git", "") | |
| return f"{domain}/{repo_path}" |
| url = self._convert_git_ssh_url_to_https() | ||
| if url.endswith(".git"): | ||
| url = url[:-4] | ||
| if "github" in url: |
There was a problem hiding this comment.
| if "github" in url: | |
| if url.startswith("https://github.com"): |
I wonder if this might be a bit more resilient?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| url = self.repo_url | ||
| if url.startswith("git@"): | ||
| url = self._convert_git_ssh_url_to_https() | ||
| if url.startswith("https://github.com"): |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
| url = self._convert_git_ssh_url_to_https() | ||
| if url.startswith("https://github.com"): | ||
| return f"{url}/tree/{version}" | ||
| if url.startswith("https://gitlab.com"): |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
| return f"{url}/tree/{version}" | ||
| if url.startswith("https://gitlab.com"): | ||
| return f"{url}/-/tree/{version}" | ||
| if url.startswith("https://bitbucket.org"): |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
This PR adds view_url to Dagbundles to enable viewing the bundle's version