Add HTTP retry handling into task SDK api.client #45121
Open
+155
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
task_sdk/tests/api/test_client.py:101
- There is an extra single quote in the mounts dictionary key. It should be mounts={'http://': httpx.MockTransport(mock_handle_request)}.
mounts={'http://': httpx.MockTransport(mock_handle_request)},
jscheffl
force-pushed
the
feature/44355-add-retry-handling-into-task-sdk-api-client
branch
from
bc58ae6 to
5399ace
Compare
jscheffl
force-pushed
the
feature/44355-add-retry-handling-into-task-sdk-api-client
branch
from
5399ace to
23614f0
Compare
amoghrajesh
reviewed
Dec 23, 2024
jscheffl
force-pushed
the
feature/44355-add-retry-handling-into-task-sdk-api-client
branch
from
23614f0 to
aaabd09
Compare
jscheffl
force-pushed
the
feature/44355-add-retry-handling-into-task-sdk-api-client
branch
from
aaabd09 to
b1878bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #44355
Add HTTP retry handling to Task SDK.