-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'NoneType' object has no attribute 'has_task' #41872
base: main
Are you sure you want to change the base?
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Can you add a test for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What TP suggested + small refactoring :)
Note for committer: please backport to v2-10-test
.
if not os.path.exists(correct_maybe_zipped(dag_to_wait.fileloc)): | ||
raise AirflowException(f"The external DAG {self.external_dag_id} was deleted.") | ||
|
||
refreshed_dag_info = DagBag(dag_to_wait.fileloc).get_dag(self.external_dag_id) | ||
if not refreshed_dag_info: | ||
raise AirflowException(f"The external DAG {self.external_dag_id} was deleted.") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if not os.path.exists(correct_maybe_zipped(dag_to_wait.fileloc)): | |
raise AirflowException(f"The external DAG {self.external_dag_id} was deleted.") | |
refreshed_dag_info = DagBag(dag_to_wait.fileloc).get_dag(self.external_dag_id) | |
if not refreshed_dag_info: | |
raise AirflowException(f"The external DAG {self.external_dag_id} was deleted.") | |
refreshed_dag_info = DagBag(dag_to_wait.fileloc).get_dag(self.external_dag_id) | |
if not (os.path.exists(correct_maybe_zipped(dag_to_wait.fileloc)) and refreshed_dag_info): | |
raise AirflowException(f"The external DAG {self.external_dag_id} was deleted.") |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
Fix 'NoneType' object has no attribute 'has_task'
I got an error, somehow refreshed_dag_info is null
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.