Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the red color to be actually red, instead of orange #1112

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SeiRann
Copy link

@SeiRann SeiRann commented Dec 20, 2024

#f55522 -> #f52222


  • I understand that contributing to this repository will require me to agree with the CLA

Description

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI

Related Tickets & Documents

#1097

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 tech-docs
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

nope

Copy link

github-actions bot commented Dec 20, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@SeiRann
Copy link
Author

SeiRann commented Dec 20, 2024

I have read the CLA Document and I hereby sign the CLA

@SeiRann
Copy link
Author

SeiRann commented Dec 20, 2024

recheck

@SeiRann SeiRann mentioned this pull request Dec 20, 2024
3 tasks
@SeiRann
Copy link
Author

SeiRann commented Dec 20, 2024

I couldn't provide any screenshot as I can't build the project from source because of my unstable internet, if you can test it let me know.

@alessandromrc
Copy link
Contributor

@SeiRann you should modify the red color also in

--color-red: #f55522;
and
.cover.type2.red { background-color: #f55522 !important; }

Then the result will be this one:

Screenshot 2024-12-21 at 01 43 44

@SeiRann
Copy link
Author

SeiRann commented Dec 21, 2024

doing that rn!

@alessandromrc
Copy link
Contributor

LGTM... And also Red ;)

@SeiRann
Copy link
Author

SeiRann commented Dec 21, 2024

good stuff, for something changed in the github editor lmao, hopefully our swiss friends wake up and approve this
:)

@alessandromrc
Copy link
Contributor

good stuff, for something changed in the github editor lmao, hopefully our swiss friends wake up and approve this :)

It's currently late in Switzerland (01:52 am) so I guess we'll have to wait ;)

@SeiRann
Copy link
Author

SeiRann commented Dec 25, 2024

@ra3orblade can you check this out?

@alessandromrc
Copy link
Contributor

@ra3orblade can you check this out?

🎄🎄🎄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants