Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace ezsapawn w/ tinyexec #136

Merged
merged 3 commits into from
Aug 27, 2024
Merged

refactor: replace ezsapawn w/ tinyexec #136

merged 3 commits into from
Aug 27, 2024

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Aug 22, 2024

Description

Replacing ezspawn with a even lighter library, see also antfu-collective/install-pkg#14

Linked Issues

N/A

Additional context

antfu-collective/install-pkg#14

@SukkaW SukkaW marked this pull request as draft August 22, 2024 04:15
@SukkaW
Copy link
Contributor Author

SukkaW commented Aug 22, 2024

Hold for antfu-collective/install-pkg#14 (comment) tinylibs/tinyexec#32

@SukkaW SukkaW marked this pull request as ready for review August 25, 2024 20:34
@SukkaW
Copy link
Contributor Author

SukkaW commented Aug 25, 2024

[email protected] now throws an error when the process has a non-zero exit code. The PR is ready to be reviewed now.

cc @antfu

benmccann
benmccann suggested changes Aug 26, 2024
View reviewed changes
Copy link

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to set the throwOnError: true option

@SukkaW
Copy link
Contributor Author

SukkaW commented Aug 26, 2024

you need to set the throwOnError: true option

Done. Since 0.3.0 is a major version bump compared to 0.2.0, I thought the option has been enabled by default now.

@antfu antfu merged commit aa72187 into antfu-collective:main Aug 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann requested changes

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SukkaW @benmccann @antfu