-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(form):Create resizable drawer #7288
Conversation
我对 api 有一些疑问,我觉得这样会好一些 resize={{
onResize:(size)=>{}
}}
resize=false
resize={{}} |
do u still have a lot of keys inside resize? or is it only onResize? |
packages/form/src/components/ModalForm/demos/visible-on-visible-change.tsx
Fixed
Show fixed
Hide fixed
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7288 +/- ##
==========================================
- Coverage 97.89% 97.72% -0.18%
==========================================
Files 338 339 +1
Lines 11282 11335 +53
Branches 4108 4125 +17
==========================================
+ Hits 11045 11077 +32
- Misses 198 219 +21
Partials 39 39
☔ View full report in Codecov by Sentry. |
@natashaamin can you add some unit test about it, coverage was a little updown |
Currently, there is only 'onResize' available, but in the future, there might be additional features added, such as maximum width and minimum width. |
Tried to do as what you suggestion. Can you help me take a look into it please? Thank you. |
👌 |
Screen.Recording.2023-06-27.at.11.53.54.AM.online-video-cutter.com.mp4
By adding new api called isResizable, user will be able to change the width of the drawer by dragging it. It gives a flexible way for user to have a better view of internal content.
Do let me know if there i any changes need to improve. I really appreciate the afford to review it. Thank you!