Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bn language support #227

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mortuzahossain
Copy link

Added Bangla Language Support with Bangla Digits
Changes:

  • Added the BnMessages class to use Bangla language and digits.
  • Added the BnShortMessages class to use Bangla short forms and digits.

Details:

  • All time-related messages in BnMessages now use Bangla numerals and text.
  • All time-related messages in BnShortMessages now use Bangla short forms and numerals.
  • Implemented convertToBanglaNumerals to handle the conversion of digits to Bangla numerals for consistency in both classes.
  • This update ensures that users receive time-related messages in Bangla, enhancing the user experience for Bangla-speaking users.

@mortuzahossain
Copy link
Author

Dear @andresaraujo,

Please accept the PR and update the code as necessary.

Thanks in advance!

@ishafiul
Copy link
Contributor

ishafiul commented Jul 4, 2024

already opened a pr for this! #224

@andresaraujo
Copy link
Owner

I merged @ishafiul language support for bn, if there is something needed to update in this locale can you update your PR @mortuzahossain ?

@mortuzahossain
Copy link
Author

@ishafiul The number was still in English and there were some issues with the short message. This is why I have added this PR. @andresaraujo I have resolved these issues, and you can now merge these changes. @ishafiul Please verify these changes and feel free to make any adjustments if needed.

@ishafiul
Copy link
Contributor

ishafiul commented Jul 5, 2024

@mortuzahossain, I think digit mapping is important and we need this. suffixFromNow can be changed, although both are the same. Regarding প্রায়, I was confused. I thought it needs to be under users' control, whether users want to use it or not. As for short messages, I have never seen Bengali clock short form like this. please give me some reference. so that we can find a common ground.

@mortuzahossain
Copy link
Author

Incorporated changes to align with @ishafiul's recommendations.

@ishafiul, please review the changes. If everything is okay, then @andresaraujo please merge the code.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants