Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zod-openapi): do not mutate original schema with extendApi #174

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

Ugzuzg
Copy link
Contributor

@Ugzuzg Ugzuzg commented Nov 29, 2023

I was trying to describe some fields of the same "primitive" type that I created with zod in different places of the API, but extendApi was overriding the description on that type instead of changing the description for that specific use case.

A solution is to not mutate the original schema with extendApi.

Copy link

nx-cloud bot commented Nov 29, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit af16fa8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@Brian-McBride
Copy link
Contributor

@Ugzuzg Can you resolve the conflicts and push again? This seems like a logical fix.

Copy link

nx-cloud bot commented Jan 18, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6684ca6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@Ugzuzg
Copy link
Contributor Author

Ugzuzg commented Jan 23, 2024

@Brian-McBride, it is done.

@Brian-McBride Brian-McBride merged commit 4d53953 into anatine:main Jan 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants