Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme #442

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Dark theme #442

wants to merge 2 commits into from

Conversation

parasss19
Copy link

Description

  • Added the dark theme
  • used google icons for dark mode button which is imported in navbar.module.css
  • Added the dark mode button inside hamburger icon for mobile screen

Pull Request Checklist

Please make sure that your PR meets the following requirements:

  • [ x] The app is working correctly after applying the changes.
  • [ x] The app is responsive and displays properly on different screen sizes and devices.
  • [x ] The changes are thoroughly documented in the appropriate files or documentation sections.
  • [x ] The coding conventions and style guidelines are followed consistently.

Checklist

Please check all applicable boxes and provide any additional information if needed.

  • [x ] I have tested the changes locally and ensured that the app is functioning as expected.
  • I have verified that the app is responsive and looks good on various screen sizes and devices.
  • [x ] I have reviewed the documentation and ensured that it accurately reflects the changes made.
  • [ x] I have followed the coding conventions and style guidelines defined in the project.
  • I have run the automated tests and all of them pass.
  • [x ] I have considered the performance implications of the changes made.
  • [x ] I have considered the security implications of the changes made.
  • [x ] I have checked for any potential regressions or side effects caused by the changes.
  • [x ] I have performed a self-review of my code.
  • [x ] Starred the repository.
  • Added My Name to the Contributor's List.
  • [x ] Followed the repository's Contributing Guidelines.
  • [x ] I ran the app and tested it locally to verify that it works as expected.

Screenshots - If Any (Optional)

Amupedia.-.Google.Chrome.2023-06-21.14-16-06_Trim.mp4

Related Issues

Just one issue that is the hero section image is remain same in dark mode

Reviewers

@anmode Please review the changes

@vercel
Copy link

vercel bot commented Jun 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
project-amupedia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 8:53am

@github-actions
Copy link

Thank you, @parasss19, for creating this pull request and contributing to GitHub-ReadMe! 💗

Our review team will thoroughly review the pull request and will reach out to you soon! 😇
Please make sure you have marked all the completed tasks as done. ✅
We appreciate your patience and contribution! 😀

@github-actions github-actions bot added the gssoc23 This is label for GirlScript Summer of Code label Jun 21, 2023
@parasss19
Copy link
Author

parasss19 commented Jun 21, 2023

Hi @anmode

@anmode
Copy link
Member

anmode commented Jun 22, 2023

Screenshot 2023-06-22 at 5 38 01 PM Please as I said dark mode is not - white to black I really need efforts to design and give property to each part of website how it behave when dark mode is applied.

@tusharbansal22
Copy link
Contributor

@parasss19 are you working to improve the dark mode or shall we close this?

Copy link
Contributor

@tusharbansal22 tusharbansal22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update dark mode for all sections.

@parasss19
Copy link
Author

parasss19 commented Jun 25, 2023

Update dark mode for all sections.

hey @tusharbansal22 can you provide the color theme you want in website?

@Harshil-Jani
Copy link
Collaborator

@parasss19 If you are blocked on color theme, Please feel free to use the one which soothes your vision. As long as the feature is functional we are okay with it. Since this PR has been inactive since a long time, Can you please give us a ping that you are still willing to make progress. Thanks.

@parasss19
Copy link
Author

@parasss19 If you are blocked on color theme, Please feel free to use the one which soothes your vision. As long as the feature is functional we are okay with it. Since this PR has been inactive since a long time, Can you please give us a ping that you are still willing to make progress. Thanks.

Hey @Harshil-Jani my exams are on going till 17 that's why I'm not able to do any progress

@Harshil-Jani
Copy link
Collaborator

Hey @Harshil-Jani my exams are on going till 17 that's why I'm not able to do any progress

Cool no hurry @parasss19 . Hope that exams went well 😄

@tayyab-ilyas tayyab-ilyas mentioned this pull request Jul 19, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 This is label for GirlScript Summer of Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants